add/guardrail-for-octo-calls#484
Open
Micha Hobert (Isengo1989) wants to merge 3 commits intomainfrom
Open
Conversation
Micha Hobert (Isengo1989)
requested review from
Bojan Rajh (bojanrajh) and
Copilot
There was a problem hiding this comment.
Pull request overview
Adds a guard step to the manual versioning workflow so schema-generation jobs only run when the provided shopware_version matches the expected version family for the currently selected branch.
Changes:
- Introduces a new
guardjob that validatesinputs.shopware_versionagainst a branch-specific regex and outputsproceed. - Updates all schema generation jobs to
needs: guardand gate execution onneeds.guard.outputs.proceed == 'true'.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Bojan Rajh (@bojanrajh) wdyt ? |
Bojan Rajh (bojanrajh)
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a guard step to the
manual_versioning.ymlGitHub Actions workflow to ensure that the provided Shopware version matches the expected version pattern for the target branch. The workflow jobs for generating schemas will now only run if the guard check passes, preventing version mismatches.Workflow validation improvements:
guardjob that checks if theshopware_versioninput matches the expected version pattern for the current branch (e.g.,v6.7.xforlatest,v6.6.xforv6.6). The job sets an output (proceed) that determines whether subsequent jobs should run.generate-trunk,generate-commercial-trunk,generate-digitalsalesroom-trunk,generate-customproducts-trunk) to depend on theguardjob and only proceed if the guard'sproceedoutput istrue, ensuring version consistency across branches.TLDR: We got PRs on latest from 6.6.x - this stops it.